[wp-cvs] wordpress wp-blog-header.php,1.88,1.89

[Mike Little]

Michel,

These changes don't smell right!

I don't think a public url in the wp-admin directory is a good idea.
Some people may want to password protect their admin directories using
Apache for example. This would then break.

Also, why not use the get_bloginfo() function (which you also changed)
in wp-blog-header.php to return the pingback url? That way there will
only be one place to make future changes to the pingback url.

Mike
-- 
Mike Little
http://zed1.com/journalized/


On Fri, 17 Sep 2004 09:27:07 +0000, Michel Valdrighi
<michelvaldrighi at users.sourceforge.net> wrote:
> Update of /cvsroot/cafelog/wordpress
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv12153
> 
> Modified Files:
>         wp-blog-header.php
> Log Message:
> now that we have a new pingback server in wp-admin/xmlrpc.php, let's advertise it
> 
> Index: wp-blog-header.php
> ===================================================================
> RCS file: /cvsroot/cafelog/wordpress/wp-blog-header.php,v
> retrieving revision 1.88
> retrieving revision 1.89
> diff -C2 -d -r1.88 -r1.89
> *** wp-blog-header.php  15 Sep 2004 07:37:43 -0000      1.88
> --- wp-blog-header.php  17 Sep 2004 09:27:04 -0000      1.89
> ***************
> *** 109,113 ****
>         header("HTTP/1.x 404 Not Found");
>   } else if ( !isset($doing_rss) || !$doing_rss ) {
> !       @header ('X-Pingback: '. get_settings('siteurl') . '/xmlrpc.php');
>   } else {
>         // We're showing a feed, so WP is indeed the only thing that last changed
> --- 109,113 ----
>         header("HTTP/1.x 404 Not Found");
>   } else if ( !isset($doing_rss) || !$doing_rss ) {
> !       @header ('X-Pingback: '. get_settings('siteurl') . '/wp-admin/xmlrpc.php');
>   } else {
>         // We're showing a feed, so WP is indeed the only thing that last changed
> ***************
> *** 116,120 ****
>         @header('Last-Modified: '.$wp_last_modified);
>         @header('ETag: '.$wp_etag);
> !       @header ('X-Pingback: ' . get_settings('siteurl') . '/xmlrpc.php');
> 
>         // Support for Conditional GET
> --- 116,120 ----
>         @header('Last-Modified: '.$wp_last_modified);
>         @header('ETag: '.$wp_etag);
> !       @header ('X-Pingback: ' . get_settings('siteurl') . '/wp-admin/xmlrpc.php');
> 
>         // Support for Conditional GET
> 
> _______________________________________________
> cvs mailing list
> cvs at wordpress.org
> http://wordpress.org/mailman/listinfo/cvs_wordpress.org
> http://wordpress.org/
>